search

processing / p5.js-website

New p5.js website!
http://p5js.org
MIT License
16 stars 82 forks source link

mouseY reference example issue #583

Open DavideConficconi opened 3 weeks ago

DavideConficconi commented 3 weeks ago

Most appropriate sections of the p5.js website?

Reference

What is your operating system?

Mac OS

Web browser and version

Firefox 131.0 ID build 20240923135042

Actual Behavior

First example of the reference should has no line drawn

Expected Behavior

describe("A horizontal black line moves up and down following the mouse's y-position."); The solution is just a simple change "line(0, mouseY, 0, mouseY);" --> line(0, mouseY, 100, mouseY);

or change that 100 to whatever is the canvas dimension

Steps to reproduce

https://p5js.org/reference/p5/mouseY/

https://github.com/processing/p5.js/blob/7d393ec4215ce20f7bc3178b779e0ec67689f928/src/events/mouse.js#L250C6-L250C33

Would you like to work on the issue?

yes, didnt had the time to read how to contribute properly, was a simple resolution

limzykenneth commented 3 weeks ago

Thanks @DavideConficconi

Changes to the reference content needs to be made on the p5.js library repo, specifically this line: https://github.com/processing/p5.js/blob/v1.11.0/src/events/mouse.js#L250, so that it can persists across version or it will be overwritten by new releases.

shourysingh07 commented 2 weeks ago

@DavideConficconi I would like to work on this issue, can you assign it to me ?

shourysingh07 commented 2 weeks ago

Hi @limzykenneth @davepagurek @Qianqianye ! I've opened a pull request addressing this issue within p5.js library repo.

Here is the PR Link.