processing / p5.js-website

New p5.js website!
http://p5js.org
MIT License
18 stars 90 forks source link

added vertical margin to nav items #633

Open whoisveroniica opened 1 week ago

whoisveroniica commented 1 week ago

Resolves #612 by adding vertical margin to navigation items.

Margin value was picked to match jump to section margin value, mentioned in the issue.

Branch cotaines one failing test although, it also occurs in the main branch. So I decided to leave it as-is.

Below I attached screenshots showing before and after.

Desktop before Desktop after
p5 - original p5 - padding
Mobile before Mobile after
p5mobile - original p5mobile - padding
davepagurek commented 6 days ago

Somewhere we have a breakpoint adding a min-height to the main nav so that when the window height is small, we don't get scroll bars on the main nav, just on the section nav below it. Do we need to update that min height here too? Currently I believe it's 350px, might need to be increased.