processing / p5.js

p5.js is a client-side JS platform that empowers artists, designers, students, and anyone to learn to code and express themselves creatively on the web. It is based on the core principles of Processing. http://twitter.com/p5xjs —
http://p5js.org/
GNU Lesser General Public License v2.1
21.58k stars 3.31k forks source link

Contributor avatars are cut out in README file #6337

Closed Qianqianye closed 1 year ago

Qianqianye commented 1 year ago

Most appropriate sub-area of p5.js?

p5.js version

No response

Web browser and version

No response

Operating System

No response

Steps to reproduce this

In the Contributors session of the README file, the most right profiles are cut out, the avatar size are not even (see screenshot below). The avatar grid can be 'scrolled 'horizontally. At the All Contributor GitHub repo, the avatars are not cut out, though the size is not even as well.

image

In .all-contributorsrc file, the image size is set in this line below:

  "imageSize": 100,

Wondering if @gr2m might have any thoughts on it? Thanks.

gr2m commented 1 year ago

thank you for pinging me Q, I'll look into it

gr2m commented 1 year ago

The problems seems to be that some of the names make the columns wider than the 100px images. If I edit the HTML directly and remove all but the first two columns it works as it should:

Image

I would suggest we make the images 120px wide and only render 6 pictures per row, that should render nicely. Would that work?

gr2m commented 1 year ago

https://github.com/processing/p5.js/pull/6341

Qianqianye commented 1 year ago

Thanks @gr2m! The solution works great. We recently noticed that our 'all contributor' count All Contributors is less than the 'code-contributor' count at the side bar (screenshot below), because we forgot to add some of the 'code-contributors' in the 'all contributor' list. Is there a recommended way to check the non-added 'code-contributors' and add them to the all contributor list?

image
gr2m commented 1 year ago

less than the 'code-contributor' count at the side bar (screenshot below)

where is that from? I cannot find it?

Is there a recommended way to check the non-added 'code-contributors' and add them to the all contributor list?

There is no simple way to add many folks with many contributions at once yet, but I can try to use the all-contributors CLI for it. I can also write a script to compare the users added to the all contributors list and whatever the Contributors from your screenshot is

gr2m commented 1 year ago

ahh sorry I know now what that screenshot is :) Let me look into it

gr2m commented 1 year ago

Here is a script to get all repository contributors logins: https://runkit.com/gr2m/get-all-repository-contributors-logins

result lmccart, allcontributors[bot], outofambit, Spongman, stalgiag, limzykenneth, therewasaguy, davepagurek, Qianqianye, inaridarkfox4231, montoyamoraga, indefinit, evhan55, dhowe, shiffman, sanketsingh24, kjhollen, asukaminato0721, jesi-rgb, wong-justin, almchung, akshay-99, toolness, Aloneduckling, futuremarc, AidanNelson, vijithassar, meiamsome, ecridge, aferriss, ihsavru, hsab, kadamwhite, mindofmatthew, dependabot[bot], Jared-Sprague, JetStarBlues, nickmcintyre, Zalastax, AdilRabbani, workergnome, mikewesthad, thethp, bomoko, hackertron, Ajayneethikannan, lm-n, weslord, jatin33, aditya-shrivastavv, fenilgandhi, DarkPrince304, codeanticode, jshaw, Zearin, TanviKumar, willmartian, abhinavsagar, kevinbarabash, L05, manpreeeeeet, OhJia, zelf0, ShenpaiSharma, bobholt, tawez, MostafaEwis, sarahghp, tau-, stinedec, bansalnitish, mojosoeun, OleksiiBulba, brightredchilli, austince, min-kim42, hkirat, SanjaySinghRajpoot, stellartux, GoToLoop, reejuBhattacharya, hrishit, singhvisha, CleezyITP, mgold, xyfeng, stampyzfanz, siv2r, vipulrawat, DivyamAhuja, yinhwa, PaliwalSparsh, CrypticGuy, tafsiri, taseenb, banditelol, sixhat, m90, munusshih, smrghsh, dhruvs009, ffd8, JithinKS97, hellonearthis, yukienomiya, AryanKoundal, fal-works, jmandel1027, nthe, sawaisinghh, KKVANONYMOUS, AnuragGupta93, Prateek93a, Ucodia, vedhant, idontknowjs, coreygo, darbicus, constanceyu, russomf, limikael, dhoizner, ozramos, ghalestrilo, aatishb, thatguyseven, calebfoss, chiunhau, zaerl, eltociear, quinton-ashley, LadySith, tstefanich, Ayush23Dash, duskvirkus, Brahvim, JunShern, ctlusto, DoubleJump, kaganjd, xujenna, jeong, alterebro, keho98, max0410, nikhilhvr, Rahulm2310, wxs, micuat, eJohnstonePhd1991, sakshamsaxena, SilasVM, anagondesign, akashraj9828, dummyAccount22, msub2, EndBug, hscdl, dexter1691, DonKarlssonSan, J-888, KevinGrajeda, LisaMabley, Luxapodular, cambridgemike, nsmarino, peilingjiang, Prateek462003, raclim, SachinVarghese, antiboredom, scottgarner, diwi, aLyonsGH, anpanring, digitalfrost, reijovosu, ggorlen, Amethystix, seagalputra, sz245, ismailnamdar, joshuaalm, linnhallonqvist, arihantparsoya, aceslowman, endurance21, awelles, Acha0203, islemaster, brysonian, epramer-godaddy, gregsadetsky, haideralipunjabi, jtnimoy, wxactly, JimishF, JoeCastor, lawreka, kennethdmiller3, leslieyip02, AliLordLoss, maddyfisher, marcusparsons, minortext, njoubert, iamrajiv, samdelong, sm7515, piinthecloud, iamutkarshtiwari, ykabusalah, agrshch, emclaren, fisherdiede, Neilblaze, nicu-chiciuc, paollabd, shinytang6, sparshg, yogitheboss, Gaweph, stevengreens10, verma-varsha, nikolas, hamoid, aditya-siddheshwar, aemonm, ameybhavsar24, AndrasGardos, anniemckinnon, radialglo, Aqmalp99, iashris, BharathKumarRavichandran, carolinehermans, crecord, stu01509, connieliu0, danarmulder, kant, Decoy4ever, DavidWeiss2, FreddieRa, Gracia-zhang, gr2m, guilhermesilveira, jpdutoit, JaiKotia, awarua, plural, JuanIrache, junagao, justinsunho, kate-grant, katiejliu, OsakaStarbux, LakshSingla, Nekzuris, maxdevjs, nthitz, niki-ito, oshoham, pmarsh-scottlogic, robynitp, r21nomi, sk1122, polyrhythmatic, sheamusburns, Siphonophora, stormCup, Stefterv, Swapnil-2001, two-ticks, bekicot, yifanmai, yutinglu413, zenozeng, zoeingram, ashu8912, cacoollib, darkcoderrises, jhongover9000, jjkaufman, kroko, liampuk, nully0x, nakul-shahdadpuri, nebbles, odm275, risingBirdSong, satyasaibhushan, smilee, wmmnola, xty, zoalst, aaronccasanova, AkashGutha, ajspadial, hydrosquall, 13sfaith, shakeabi, N4M3L355, acasmith, adwaith007, tito21, al6862, AndrasGG, IamEzio, arbaaz, ArshM17, kangashley, code4humanity, a-y-u-s-h, beau-muylle, bmoren, brmscheiner, rbwendt, Benjamin-Davies, dabe, BerfinA, Bernice55231, etrepum, bwhitman, bryanrtboy, bulkan, caitelatte, calebegg, Maikuolan, camilleroux, REAS, quinox, chechenxu, ChinmayKadam172, ChrisJohnRyan, b4ux1t3, christhomson, cdfuller, frewsxcv, cosmeoes, daniel-michel, dansarno, meodai, dwight9339, sansumbrella, frigorific44, demc, cotsog, edbrannin, with-a-k, GABBAR1947, glneto
gr2m commented 1 year ago

I updated the script to also load users from the .all-contributorsrc file and to log out the diff: https://runkit.com/gr2m/get-all-repository-contributors-logins/2.0.0

136 code contributors missing in .all-contributorsrc file

logins of missing code contributors 13sfaith, Acha0203, AdilRabbani, AidanNelson, Ajayneethikannan, AkashGutha, AliLordLoss, Amethystix, AndrasGG, AndrasGardos, Aqmalp99, ArshM17, Benjamin-Davies, BerfinA, Bernice55231, ChrisJohnRyan, GABBAR1947, Gracia-zhang, J-888, JaiKotia, JithinKS97, JoeCastor, JuanIrache, JunShern, LadySith, LakshSingla, Maikuolan, N4M3L355, Neilblaze, OleksiiBulba, Prateek93a, SachinVarghese, Siphonophora, Stefterv, a-y-u-s-h, aaronccasanova, acasmith, aditya-siddheshwar, adwaith007, aemonm, allcontributors[bot], anagondesign, arbaaz, arihantparsoya, asukaminato0721, awarua, beau-muylle, bekicot, brmscheiner, bryanrtboy, bulkan, bwhitman, cacoollib, caitelatte, calebegg, cdfuller, constanceyu, cosmeoes, cotsog, dabe, danarmulder, demc, dependabot[bot], dhoizner, digitalfrost, diwi, dummyAccount22, duskvirkus, eJohnstonePhd1991, edbrannin, emclaren, epramer-godaddy, etrepum, fal-works, frewsxcv, glneto, gr2m, hellonearthis, hscdl, iashris, idontknowjs, ihsavru, jatin33, jeong, jesi-rgb, jhongover9000, jmandel1027, junagao, kangashley, kant, leslieyip02, linnhallonqvist, m90, maddyfisher, manpreeeeeet, meodai, micuat, min-kim42, minortext, nebbles, nikhilhvr, niki-ito, nikolas, nully0x, odm275, paollabd, quinox, r21nomi, rbwendt, reijovosu, risingBirdSong, sarahghp, seagalputra, shakeabi, sheamusburns, shinytang6, smrghsh, stalgiag, stellartux, stormCup, stu01509, sz245, tau-, tawez, tito21, vedhant, verma-varsha, vipulrawat, with-a-k, wmmnola, xty, xujenna, yifanmai, yinhwa, ykabusalah, zoalst
gr2m commented 1 year ago

Actually, this feature is built into the CLI 🤣

npx all-contributors-cli check

docs: https://allcontributors.org/docs/en/cli/usage#all-contributors-check

gr2m commented 1 year ago

ready: https://github.com/processing/p5.js/pull/6349