search

processing / p5.js

p5.js is a client-side JS platform that empowers artists, designers, students, and anyone to learn to code and express themselves creatively on the web. It is based on the core principles of Processing. http://twitter.com/p5xjs —
http://p5js.org/
GNU Lesser General Public License v2.1
21.59k stars 3.31k forks source link

Adding missing examples to the documentation. #6751

Open deveshidwivedi opened 9 months ago

deveshidwivedi commented 9 months ago

Resolves #6750

Changes: Added some of the missing examples.

Before:

Screenshot 2024-01-17 201617

After:

Screenshot 2024-01-20 000144

PR Checklist

davepagurek commented 9 months ago

It looks like currently tests are failing from a linting error:

Running "eslint:source" (eslint) task
/home/runner/work/p5.js/p5.js/src/dom/dom.js:4664:72: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/webgl/p5.Geometry.js:310:16: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/webgl/p5.Geometry.js:311:16: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/webgl/p5.Geometry.js:329:53: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/webgl/p5.Geometry.js:944:59: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/webgl/p5.Geometry.js:947:3: Trailing spaces not allowed. [Error/no-trailing-spaces]

(I haven't taken a closer look just yet at the changes, I'll do that soon. Thanks for taking on this task and adding so many examples!)

deveshidwivedi commented 9 months ago

I'll fix these..

perminder-17 commented 9 months ago

Thank you @deveshidwivedi for raising this point. It's essential for new learners who may struggle with understanding concepts without clear examples. Your examples are excellent. I'd like to add a few cleanup for this one. :)

deveshidwivedi commented 9 months ago

Thank you!@perminder-17 Please share any suggestions for refinement you may have.

perminder-17 commented 9 months ago

Oops Idk why my review is not showing up, maybe due to the access. Sharing the screenshots though :')

review

review2

limzykenneth commented 9 months ago

@perminder-17 You seem to have started the review but not submitted it, on the top right of the code review page you need to press "Review changes" > "Submit review" for it to show up.

perminder-17 commented 9 months ago

@perminder-17 You seem to have started the review but not submitted it, on the top right of the code review page you need to press "Review changes" > "Submit review" for it to show up.

Thanks... My bad😂