Fix filters run on framebuffers with different sizes from the main canvas

processing / p5.js

p5.js is a client-side JS platform that empowers artists, designers, students, and anyone to learn to code and express themselves creatively on the web. It is based on the core principles of Processing. http://twitter.com/p5xjs —

http://p5js.org/

GNU Lesser General Public License v2.1

21.2k stars 3.23k forks source link

Fix filters run on framebuffers with different sizes from the main canvas #6783

Closed davepagurek closed 5 months ago

davepagurek commented 5 months ago

Resolves #6782

Changes:

Uses target.width and target.height more consistently to handle cases where target !== this
Adds visual tests

Screenshots of the change:

Before:

https://editor.p5js.org/davepagurek/sketches/gRuscBCcH

After:

https://editor.p5js.org/davepagurek/sketches/gRuscBCcH

PR Checklist

[x] npm run lint passes
x is included / updated
x are included / updated

davepagurek commented 5 months ago

@perminder-17 does this seem ok to you?