search

processing / p5.js

p5.js is a client-side JS platform that empowers artists, designers, students, and anyone to learn to code and express themselves creatively on the web. It is based on the core principles of Processing. http://twitter.com/p5xjs β€”
http://p5js.org/
GNU Lesser General Public License v2.1
21.13k stars 3.23k forks source link

[p5.js KO] Create contributor_guidelines.md #6855

Closed yunyoungJang closed 3 months ago

yunyoungJang commented 3 months ago

Resolves #[Add issue number here]

Changes:

Screenshots of the change:

PR Checklist

welcome[bot] commented 3 months ago

πŸŽ‰ Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

yinhwa commented 3 months ago

thanks @yunyoungJang for initializing this file! @YewonCALLI can start collaborating on this as well.

yinhwa commented 3 months ago

μœ€μ˜λ‹˜ @yunyoungJang λΉ λ₯Έμž‘μ—… κ°μ‚¬λ“œλ¦½λ‹ˆλ‹€πŸ©΅πŸ˜Š μ„Έμ§„λ‹˜ μ €λŠ” 였늘 μ €λ…μ‹œκ°„ μ΄ν›„λ‘œ 리뷰 κ°€λŠ₯ν•©λ‹ˆλ‹€ @designerSejinOH

designerSejinOH commented 3 months ago

κ°μ‚¬ν•©λ‹ˆλ‹€β˜ΊοΈ μœ€μ˜λ‹˜ @yunyoungJang!! μΈν™”λ‹˜ 저도 λ°€(10μ‹œ 이후)에 리뷰 λ³Ό μ˜ˆμ •μž…λ‹ˆλ‹€~! @yinhwa

yunyoungJang commented 3 months ago

@yinhwa @designerSejinOH @ienground @wooknick μ œκ°€ μ•„λ¬΄λž˜λ„ 개발이 μ£Ό 전곡이 μ•„λ‹ˆμ—¬μ„œ κ·ΈλŸ°μ§€ μŒμ°¨λ²ˆμ—­ κ·ΈλŒ€λ‘œ μ‚¬μš©ν•˜λŠ” λ‹¨μ–΄λ‚˜, 개발 μ˜μ—­ λ‚΄ 주둜 μ‚¬μš©ν•˜λŠ” μš©μ–΄κ°€ μ–΄λ ΅λ”λΌκ΅¬μš”. 주둜 혼자 κ°œλ°œκ³΅λΆ€λ₯Ό ν•˜κ±°λ‚˜ μ†Œμˆ˜λΌλ¦¬ ν˜‘μ—…μ„ ν•΄μ™€μ„œ λ²ˆμ—­μ—μ„œ 혼용되게 μ„œμˆ ν•œ 점이 μžˆμ—ˆμŠ΅λ‹ˆλ‹€! μš°μ„  'μ €μž₯μ†Œ' -> '리포지토리'둜 바꿔두도둝 ν• κ²Œμš”~~!

yinhwa commented 3 months ago

@designerSejinOH μ„Έμ§„λ‹˜! μœ€μ˜λ‹˜μ΄ 1μ°¨ 리뷰 반영 μ»€λ°‹ν•΄μ£Όμ…”μ„œ, 2μ°¨ 리뷰 μ§„ν–‰ν•˜μ‹œλ©΄ λ©λ‹ˆλ‹€!

designerSejinOH commented 3 months ago

@yinhwa λ„΅! λ°”λ‘œ μ§„ν–‰ν•˜κ² μŠ΅λ‹ˆλ‹€! λ…Έν‹° κ°μ‚¬ν•©λ‹ˆλ‹€!

yinhwa commented 3 months ago

@yunyoungJang μœ€μ˜λ‹˜! μ•„λž˜ κ°€μ΄λ“œλΌμΈμ— 따라, ν˜„μž¬ μž‘μ—…μ€‘μ΄μ‹  yunyoungJang : patch-1 fork에 λŒ€ν•œ μ“°κΈ° κΆŒν•œμ„ @yewonCALLI μ˜ˆμ›λ‹˜κ»˜ 곡유 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€! μ“°κΈ° κΆŒν•œμ΄ 곡유된 이후에 μ˜ˆμ›λ‹˜μ΄ μž‘μ—… μ‹œμž‘ κ°€λŠ₯ν•©λ‹ˆλ‹€ :)

Maintainer Kenneth Lim λ‹˜ 곡유 κ°€μ΄λ“œλΌμΈ (24.03.18) : https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-teams-and-people-with-access-to-your-repository

yunyoungJang commented 3 months ago

@YewonCALLI μ˜ˆμ›λ‹˜ κΆŒν•œμš”μ²­κ°”λŠ”μ§€ ν™•μΈλΆ€νƒλ“œλ €μš”!

yunyoungJang commented 3 months ago

@yinhwa, @designerSejinOH κΆŒν•œ μš”μ²­ ν™•μΈλΆ€νƒλ“œλ¦½λ‹ˆλ‹€ πŸ™Œ

designerSejinOH commented 3 months ago

@yinhwa, @designerSejinOH κΆŒν•œ μš”μ²­ ν™•μΈλΆ€νƒλ“œλ¦½λ‹ˆλ‹€ πŸ™Œ

κΆŒν•œ μŠΉμΈν–ˆμŠ΅λ‹ˆλ‹€. κ°μ‚¬ν•©λ‹ˆλ‹€!

YewonCALLI commented 3 months ago

μ €ν•œν…Œ conversation resolve λ²„νŠΌμ΄ 보이지 μ•ŠλŠ” 것 κ°™μ•„μš”γ…œγ…œ!! @designerSejinOH λ‹˜μ΄ μˆ˜μ •ν•΄μ£Όμ‹  λΆ€λΆ„ λ°˜μ˜ν•˜μ—¬ μ»€λ°‹μ˜€μŠ΅λ‹ˆλ‹€.

Qianqianye commented 3 months ago

Looks great, thanks @yunyoungJang @designerSejinOH @yinhwa @YewonCALLI πŸ’“ @all-contributors please add @yunyoungJang for translation

allcontributors[bot] commented 3 months ago

@Qianqianye

I've put up a pull request to add @yunyoungJang! :tada:

Qianqianye commented 3 months ago

@all-contributors please add @YewonCALLI for translation

allcontributors[bot] commented 3 months ago

@Qianqianye

I've put up a pull request to add @YewonCALLI! :tada:

Qianqianye commented 3 months ago

@all-contributors please add @designerSejinOH for translation, review

allcontributors[bot] commented 3 months ago

@Qianqianye

I've put up a pull request to add @designerSejinOH! :tada:

Qianqianye commented 3 months ago

Hi @yunyoungJang @yinhwa @designerSejinOH, we just noticed that all the images are not showing on the ko/contributor_guidelines.md or the other translated Korean contributor docs from this week.

The English version of the contributor docs and the images folder are in the contributor_docs parent folder, and the Korean translated docs are in the contributor_docs/ko child folder. So we need to reconfigure the image paths. Sorry we didn't catch this issue earlier.

Could you ask the contributors to add '.../' at front of the image the path, so it'd be '../images/xxxx.png'? You can see es/contributor_guidelines.md as example. Thank you!

yinhwa commented 3 months ago

Hi @yunyoungJang @yinhwa @designerSejinOH, we just noticed that all the images are not showing on the ko/contributor_guidelines.md or the other translated Korean contributor docs from this week.

The English version of the contributor docs and the images folder are in the contributor_docs parent folder, and the Korean translated docs are in the contributor_docs/ko child folder. So we need to reconfigure the image paths. Sorry we didn't catch this issue earlier.

Could you ask the contributors to add '.../' at front of the image the path, so it'd be '../images/xxxx.png'? You can see es/contributor_guidelines.md as example. Thank you!

Thanks Q for figuring this out, and sorry we missed this out. We should've double checked on this. Could any of @yunyoungJang or @YewonCALLI kindly edit the image paths and pull a new PR on this? Thank you all πŸ™

@designerSejinOH

wooknick commented 3 months ago

@yinhwa ν˜Ήμ‹œλ‚˜ ν•΄μ„œ ν™•μΈν•΄λ³΄λ‹ˆ μ œκ°€ λ‹΄λ‹Ήν–ˆλ˜ λ¬Έμ„œλ„ 이미지가 κΉ¨μ Έμžˆλ„€μš”.. λ‹€μ‹œ PR μ˜¬λ¦¬κ² μŠ΅λ‹ˆλ‹€

designerSejinOH commented 3 months ago

@wooknick ν™•μΈν•΄λ΄μ£Όμ…”μ„œ κ°μ‚¬ν•©λ‹ˆλ‹€..! μˆ˜μ • PRμ˜¬λ¦¬μ‹œλ©΄ λ°”λ‘œ ν™•μΈν•΄μ„œ 머지 μš”μ²­λ“œλ¦΄κ²Œμš”!

@ienground @Orwiss ν˜„μš°λ‹˜, μ„±ν›ˆλ‹˜λ„ μ£„μ†‘ν•˜μ§€λ§Œ, μž‘μ—…ν•΄μ£Όμ…¨λ˜ λ¬Έμ„œμ— 이미지 경둜 ν•œ 번 확인 λΆ€νƒλ“œλ €λ„ λ κΉŒμš”?? 이미지 κ²½λ‘œλŠ” '../images/xxxx.png' 이런 μ‹μœΌλ‘œ 저희 ko 폴더 μƒμœ„μ— μžˆλŠ” 경둜둜 μˆ˜μ •ν•΄μ£Όμ‹œλ©΄ 될 것 κ°™μŠ΅λ‹ˆλ‹€..! μˆ˜μ • ν›„ PR μ˜¬λ €μ£Όμ‹œλ©΄ λ°”λ‘œ ν™•μΈν•˜κ² μŠ΅λ‹ˆλ‹€!! κ°μ‚¬ν•©λ‹ˆλ‹€πŸ˜­

Orwiss commented 3 months ago

@designerSejinOH @ienground μ œκ°€ μ§€κΈˆ μˆ˜μ •ν• κ²Œμš”!

yunyoungJang commented 3 months ago

λ¬Έμ„œμ— μ €λž‘ μ˜ˆμ›λ‹˜ λΆ€λΆ„ λͺ¨λ‘ μƒμœ„ 경둜둜 μˆ˜μ • ν–ˆμŠ΅λ‹ˆλ‹€. @YewonCALLI μ˜ˆμ›λ‹˜λ„ ν™•μΈλΆ€νƒλ“œλ €μš”! @designerSejinOH @yinhwa

designerSejinOH commented 3 months ago

οΏ½λ¬Έμ„œμ— μ €λž‘ μ˜ˆμ›λ‹˜ λΆ€λΆ„ λͺ¨λ‘ μƒμœ„ 경둜둜 μˆ˜μ • ν–ˆμŠ΅λ‹ˆλ‹€. @YewonCALLI μ˜ˆμ›λ‹˜λ„ ν™•μΈλΆ€νƒλ“œλ €μš”! @designerSejinOH @yinhwa

@yunyoungJang λ„΅λ„΅! 저도 ν™•μΈν•΄λ³΄κ² μŠ΅λ‹ˆλ‹€! ν˜Ήμ‹œ μ–΄λ””μ—μ„œ μˆ˜μ •ν•΄μ£Όμ…¨λ‚˜μš”??

yunyoungJang commented 3 months ago

@designerSejinOH
https://github.com/processing/p5.js/compare/main...yunyoungJang:p5.js:patch-2 μœ„μ˜ 링크둜 λ“€μ–΄κ°€μ‹œλ©΄ λ©λ‹ˆλ‹€. μ œκ°€ κΉƒν—ˆλΈŒ ν˜‘μ—…μ΄ 아직 λ‚―μ„€μ–΄μ„œ 어렀움이 λ§Žλ„€μš”. μˆ˜μ •ν•΄μ•Όν•  뢀뢄이 μžˆλ‹€λ©΄ μ•Œλ €μ£Όμ„Έμš”.

designerSejinOH commented 3 months ago

@yunyoungJang μ•— μ•„λ‹ˆμ—μš”!! 잘 ν•΄μ£Όμ…¨μ–΄μš”. κ°μ‚¬ν•©λ‹ˆλ‹€β˜ΊοΈ "Create pull request"λˆŒλŸ¬μ„œ μ €λ²ˆμ²˜λŸΌ PR μ˜¬λ €μ£Όμ‹œλ©΄ κ±°κΈ°μ„œ ν™•μΈν•˜κ³  μŠΉμΈλ“œλ¦΄κ²Œμš”!