Fix usage of default fonts

processing / p5.js

p5.js is a client-side JS platform that empowers artists, designers, students, and anyone to learn to code and express themselves creatively on the web. It is based on the core principles of Processing. http://twitter.com/p5xjs —

http://p5js.org/

GNU Lesser General Public License v2.1

21.53k stars 3.3k forks source link

Fix usage of default fonts #6861

Closed davepagurek closed 6 months ago

davepagurek commented 6 months ago

Resolves https://github.com/processing/p5.js/issues/6860

Changes

Only surrounds the font in quotes if necessary (if the font includes a space)
Adds visual tests

Screenshots of the change: 000

PR Checklist

[x] npm run lint passes
[ ] [Inline documentation] is included / updated
[x] [Unit tests] are included / updated

Qianqianye commented 6 months ago

Thanks @davepagurek for reviewing it. I merged it before I saw that you requested a review from @dhowe. @dhowe, please leave comment here if you have any feedback, and we can make a new PR if needed. Thanks!

dhowe commented 6 months ago

looks good to me, thanks @davepagurek and @Qianqianye !