Fix #6847: Update mouseButton value when one mouse button is released

processing / p5.js

p5.js is a client-side JS platform that empowers artists, designers, students, and anyone to learn to code and express themselves creatively on the web. It is based on the core principles of Processing. http://twitter.com/p5xjs —

http://p5js.org/

GNU Lesser General Public License v2.1

21.11k stars 3.22k forks source link

Fix #6847: Update mouseButton value when one mouse button is released #6943

Open Renatolo opened 2 months ago

Renatolo commented 2 months ago

Resolves #6847

Changes:

Modified src/events/mouse.js to correctly update the mouseButton value upon releasing one mouse button.
Updated documentation in src/events/mouse.js accordingly.
Added unit test in test/unit/events/mouse.js to cover scenario described in the issue.
Now mouseButton should have the value corresponding to the last mouse button pressed/released

Screenshots of the change: (no screenshots)

PR Checklist

[ x ] npm run lint passes
x is included / updated
x are included / updated

welcome[bot] commented 2 months ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

limzykenneth commented 1 month ago

This technically changes the behavior of the property and is a breaking change. I don't think I can accept this solution because of it.

Renatolo commented 2 weeks ago

This technically changes the behavior of the property and is a breaking change. I don't think I can accept this solution because of it.

Thank you for spending time reviewing my PR, I looked further into this issue and learnt that the main reason that the mouseButton was not updated after a mouse release event due to possible problems caused by the context menu being opened... Should I try to make it so that the context menu woulndt interfere in its value (with it still being the default behaviour) or would it still be a breaking change?