modified stroke vertex shader

processing / p5.js

p5.js is a client-side JS platform that empowers artists, designers, students, and anyone to learn to code and express themselves creatively on the web. It is based on the core principles of Processing. http://twitter.com/p5xjs —

http://p5js.org/

GNU Lesser General Public License v2.1

21.08k stars 3.22k forks source link

modified stroke vertex shader #7064

Closed JordanSucher closed 1 month ago

JordanSucher commented 1 month ago

resolves @6956

Previously, the shader used for rendering strokes moved the stroke 'forward' by multiplying it by a scale factor.

Now, the shader subtracts a small constant from the stroke's z value instead.

This minimizes issues with strokes clipping through object faces, which because of the scale factor were worse when objects were further from the camera.

PR Checklist

[ x ] npm run lint passes
x is included / updated
are included / updated

welcome[bot] commented 1 month ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

davepagurek commented 1 month ago

@all-contributors please add @JordanSucher for bug, code

allcontributors[bot] commented 1 month ago

@davepagurek

I've put up a pull request to add @JordanSucher! :tada: