search

processing / p5.js

p5.js is a client-side JS platform that empowers artists, designers, students, and anyone to learn to code and express themselves creatively on the web. It is based on the core principles of Processing. http://twitter.com/p5xjs —
http://p5js.org/
GNU Lesser General Public License v2.1
21.08k stars 3.22k forks source link

Fix nf function to handle undefined left parameter , giving a default value and update documen… #7087

Closed VANSH3104 closed 1 week ago

VANSH3104 commented 2 weeks ago

Resolves #6994

Changes:

Screenshots of the change: Screenshot from 2024-06-06 22-55-59 Screenshot from 2024-06-06 22-55-38

PR Checklist

welcome[bot] commented 2 weeks ago

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

limzykenneth commented 1 week ago

Hi @VANSH3104, thanks for the PR. Unfortunately I don't think this is necessarily the right fix. For nf() it may not make sense to not include the left parameter and if that is the case the FES should try to catch it instead. In addition @Akhilbisht798 has already indicated in the original issue interest to tackle this problem so I would like to give them a chance first.

I would suggest continuing discussion in the original issue to find the right way to solve this, either as a code implementation, documentation, or other fixes if necessary before opening a PR when a solution is reached. I will close this PR for now. Thanks.