search

processing / processing-android-archive

96 stars 50 forks source link

Update AndroidBuild.java #53

Closed pegleg999 closed 11 years ago

pegleg999 commented 11 years ago

Change project target to 13 to enable Admob

boubpopsyteam commented 11 years ago

Not good, Min SDK have to stay to level 10 / gingerbread. http://developer.android.com/guide/topics/manifest/uses-sdk-element.html#ApiLevels

(+ for the records, your patch would have needed to change the comments at least ;)

pegleg999 commented 11 years ago

Can the code be updated so the variable is derived from the manifest xml? 

Sent from Samsung Mobile

-------- Original message -------- From: boubpopsyteam notifications@github.com Date:
To: processing/processing-android processing-android@noreply.github.com Cc: pegleg999 gordonrgreig@gmail.com Subject: Re: [processing-android] Update AndroidBuild.java (#53)

Not good, Min SDK have to stay to level 10 / gingerbread.

— Reply to this email directly or view it on GitHub.

pegleg999 commented 11 years ago

Can the variable be updated via the xml manifest instead of being hard coded?

Sent from Samsung Mobile

-------- Original message -------- From: boubpopsyteam notifications@github.com Date:
To: processing/processing-android processing-android@noreply.github.com Cc: pegleg999 gordonrgreig@gmail.com Subject: Re: [processing-android] Update AndroidBuild.java (#53)

Not good, Min SDK have to stay to level 10 / gingerbread.

— Reply to this email directly or view it on GitHub.

boubpopsyteam commented 11 years ago

Processing itself don't need it as Android is backward compatible. (that is you don't need to target your current version, an equal or lower is enough)

pegleg999 commented 11 years ago

From my research, this doesnt seem to correct, I'm trying to implement Admob, and all the forums go back to changing the target SDK to a 14 to enable some functionality

On Wed, Aug 28, 2013 at 6:37 PM, boubpopsyteam notifications@github.comwrote:

Processing itself don't need it as Android is backward compatible. (that is you don't need to target your current version, an equal or lower is enough)

— Reply to this email directly or view it on GitHubhttps://github.com/processing/processing-android/pull/53#issuecomment-23399137 .

boubpopsyteam commented 11 years ago

If admob require lvl14, do it for you. It's not processing related so don't change processing. :)

pegleg999 commented 11 years ago

Hmm.. not sure how to build the source code from scratch including the android plug in

On Wed, Aug 28, 2013 at 8:04 PM, boubpopsyteam notifications@github.comwrote:

If admob require lvl14, do it for you. It's not processing related so don't change processing. :)

— Reply to this email directly or view it on GitHubhttps://github.com/processing/processing-android/pull/53#issuecomment-23403474 .

benfry commented 11 years ago

Err, no... This would set the minimum Android version to 3.2 for anything produced with Processing. We're not ready to do that.