processing / processing-android

Processing mode and core library to create Android apps with Processing
http://android.processing.org
779 stars 293 forks source link

processing4 branch shows warning on build(Target SDK in Manifest) #678

Closed rupeshkumar22 closed 2 years ago

rupeshkumar22 commented 2 years ago

It's not a major issue and can be simply resolved. I observed that manifest.setSdkTarget is being used and some recent chages of AAB are not yet there in processing4 branch. During Gradle build in processin4, it shows a warning as Target SDK is being used in manifest and it must be used in build.gradle file.

Is processing4 planned to be an independent branch or will it be merged into the master? @codeanticode

codeanticode commented 2 years ago

I already removed target SDK from the manifest file with this commit: https://github.com/processing/processing-android/commit/afb84baed09c9e14923ef66bfedf5a592f600747

The plan is to merge the processing4 branch into main, so will be taken care when that happens.

rupeshkumar22 commented 2 years ago

Yes, it was already corrected by you in the main branch. Got it now, so closing the issue @codeanticode