search

processing / processing-android

Processing mode and core library to create Android apps with Processing
http://android.processing.org
779 stars 293 forks source link

Shortcut is invisible for `Signed Package Export` in menu. #702

Closed rupeshkumar22 closed 2 years ago

rupeshkumar22 commented 2 years ago

Some minor correction is needed, related to showing the shortcut on the right side of the option Signed Package Export in the File menu. Currently the shortcut text is not visible on the right side. Here is a minor issue on startup of mode -

'Export Signed Package.keystroke.windows' is not understood, please re-read the Java reference for KeyStroke

ranaaditya commented 2 years ago

Some minor correction is needed, related to showing the shortcut on the right side of the option Signed Package Export in the File menu. Currently the shortcut text is not visible on the right side. Here is a minor issue on startup of mode -

'Export Signed Package.keystroke.windows' is not understood, please re-read the Java reference for KeyStroke

hey @rupeshkumar22 did you face this issue earlier ?

or is this first time you are getting it ?

rupeshkumar22 commented 2 years ago

@ranaaditya It was not faced earlier. It might have been missed during the reimplementation of the Export Package Option in the menu. Earlier it was removed for some time and later it was finalized to be included as discussed by @codeanticode #693 Not a significant issue, I will do some changes to make it visible along with the major emulator PR. Thanks

ranaaditya commented 2 years ago

@ranaaditya It was not faced earlier. It might have been missed during the reimplementation of the Export Package Option in the menu. Earlier it was removed for some time and later it was finalized to be included as discussed by @codeanticode #693 Not a significant issue, I will do some changes to make it visible along with the major emulator PR. Thanks

@rupeshkumar22 just tag me in the PR, will review it ASAP 👍

ranaaditya commented 2 years ago

@processing-bugs just make the PR ASAP, you can also make a WIP PR as discussed by us.

Definetly this Emulator changes gonna be critical and major as well so you can go with a WIP PR.

You can commit changes in that PR and update us regarding the progress there also.

Thanks