search

processing / processing-website

Repository for the processing.org website
https://processing.org
GNU General Public License v2.0
64 stars 95 forks source link

Added title attributes to top bar links #429

Closed kushalnl7 closed 1 year ago

kushalnl7 commented 1 year ago

Resolved Issue - #425. Please review it and let me know the comments.

SableRaf commented 1 year ago

While reviewing your PR, I found there is a span element with Topbar-module--name--4+Tmy class that does get picked up by screen readers so the title element is redundant. Very sorry for that!

My tests also showed that the dropdown menus are not fully optimized for screen readers so this was still useful! I will create a new issue regarding the dropdowns and maybe you'll be interested to look into that? Thanks again for your efforts!

kushalnl7 commented 1 year ago

No worries @SableRaf. I will look into the other issue created by you. Thanks!