search

processing / processing-website

Repository for the processing.org website
https://processing.org
GNU General Public License v2.0
68 stars 94 forks source link

Track downloads in fathom #461

Closed runemadsen closed 1 year ago

runemadsen commented 1 year ago

This PR fixes #460 by tracking download events in Fathom Analytics. I implemented this with the useGoal that is a part of the gatsby-plugin-fathom package. It's a little annoying that we need to run a hook per goal, but the library handles a lot of stuff around dev/prod and SSR so I'd rather rely on that.

Adding @fdoflorenzano so they can take a look.

CC @SableRaf

SableRaf commented 1 year ago

Hi @runemadsen and thanks for this!

I tried all events and everything seems to be working ✨

Note: one event doesn't appear on the screenshot below because of pagination.

image

Once @fdoflorenzano gives this PR the thumbs up on the code side, I'll happily merge and release.

SableRaf commented 1 year ago

I had a closer look at the code, and it looks good to me! @fdoflorenzano do let me know if you notice anything that needs changing. In the meantime I'll go ahead with the merge. Thanks again for your help on this @runemadsen.