processing / processing-website

Repository for the processing.org website
https://processing.org
GNU General Public License v2.0
68 stars 98 forks source link

feat: Implemented border when hover #557

Closed rishabdev2997 closed 1 month ago

rishabdev2997 commented 3 months ago

feat: Highlight or add left border to active navbar subitem

487 - added the feature.

In the issue the problem was not mentioned properly(the download nav item gets a left border for distinction. The same can apply to nav sub-items.) but it seems it indicates navs under the "Table of Contents" section must display the same left border upon selection.

How to see the changes

Here is the Screenshot

https://github.com/user-attachments/assets/04af6693-633f-4602-90c8-3399463e9384

netlify[bot] commented 3 months ago

Deploy Preview for java-processing-faf822 ready!

Name Link
Latest commit 7b7bad5a2e7dd6359a8fa2cd011bd8d32258fab7
Latest deploy log https://app.netlify.com/sites/java-processing-faf822/deploys/670913887f483500087fd5d4
Deploy Preview https://deploy-preview-557--java-processing-faf822.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rishabdev2997 commented 3 months ago

Added spacing between each content items in the list

Updated Screenshot for #508

https://github.com/user-attachments/assets/9e4218f9-dd8f-4c6f-b2df-c2c9358eebb7

Stefterv commented 3 months ago

Also @SableRaf lmk if the visual changes are approved, especially regarding the spacing and fontsize changes

SableRaf commented 3 months ago

Thanks @Stefterv! Yes it looks good to me visually.

SableRaf commented 1 month ago

Hey @rishabdev2997! Just checking inβ€”are you still interested in finishing up this PR? Let me know; otherwise, I'll go ahead and close it. Thanks!

rishabdev2997 commented 1 month ago

@SableRaf I will finish it in 3 days. sorry for late reply

SableRaf commented 1 month ago

Sure thing! No worries. Thanks for your reply :) let us know if you need any support.

rishabdev2997 commented 1 month ago

I will make a new pr with the updates @SableRaf