search

processone / docker-ejabberd

Set of ejabberd Docker images
94 stars 77 forks source link

Missing ejabberd version number in ecs 24.02 image #111

Closed badlop closed 6 months ago

badlop commented 6 months ago

The ecs 24.02 container image doesn't show the proper ejabberd version number:

$ podman run -it docker.io/ejabberd/ecs:24.02
...
2024-03-04 15:19:41.206552+00:00 [info] ejabberd 0.0.0 is started in the node ejabberd@localhost in 1.20s

This worked correctly in the previous version:

$ podman run -it docker.io/ejabberd/ecs:23.10
...
2024-03-04 15:20:24.753177+00:00 [info] ejabberd 23.10.0 is started in the node ejabberd@localhost in 1.56s

It works correctly in the ejabberd container image, because that one uses a different build method based in the installers...

$ podman run -it ghcr.io/processone/ejabberd:24.02
2024-03-04 15:21:22.988324+00:00 [info] ejabberd 24.2.0 is started in the node ejabberd@localhost in 1.25s
badlop commented 6 months ago

The version number is obtained from the git tag by tests.yml using git describe --exact-match, and later is stored by Dockerfile in vars.config.

The problem this time is that I created the git tag with git tag 24.02. This creates a lightweight tag, and git describe doesn't use it.

The proper method to create the tag would have been git tag 24.02 -m "Tag for release ejabberd 24.02 that way, an annotated tag is created and git describe can find it.

To ensure that all the tags are used, including the lightweight tags, git describe --tags can be used.

This should be fixed in https://github.com/processone/docker-ejabberd/commit/228ab57d6c1b446cf67e7719e1749b17cd230789