search

processone / docker-ejabberd

Set of ejabberd Docker images
94 stars 77 forks source link

Update ACME default `ca_url` #70

Closed karimhm closed 3 years ago

karimhm commented 3 years ago

The current default ca_url (https://acme-v01.api.letsencrypt.org) rely on ACME v1 which had been deprecated.

p1bot commented 3 years ago

Hi @karimhm, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

p1bot commented 3 years ago

You did it @karimhm!

Thank you for signing the ProcessOne Contribution License Agreement.

We will have a look at your contribution!

badlop commented 3 years ago

Hi!

I see ejabberd_acme.erl uses

    <<"https://acme-v02.api.letsencrypt.org/directory">>.

Is there any reason for you to use staging?

karimhm commented 3 years ago

Hi!

I see ejabberd_acme.erl uses


    <<"https://acme-v02.api.letsencrypt.org/directory">>.

Is there any reason for you to use staging?

Because some might be using ACME improperly or even without realizing that they are using it. Staging is used to protect them from being accidentally banned or rate limited by the production ACME server.

badlop commented 3 years ago

Ok then, thanks!