search

processone / ejabberd

Robust, Ubiquitous and Massively Scalable Messaging Platform (XMPP, MQTT, SIP Server)
https://www.process-one.net/en/ejabberd/
Other
6.07k stars 1.51k forks source link

Handle newer versions of the mix namespaces #3854

Closed jbruechert closed 2 years ago

jbruechert commented 2 years ago

As far as I can see, there are no other changes to be made to add compatibility with the newer namespaces: mix:pam:1 was bumped to make archiving optional, which afaik ejabberd did not implement anyway. If it did before, it would still be compliant mix:pam:2 was bumped, in order to communicate that mix:core was bumped mix:core:1 itself was bumped to adapt the text to reflect that archiving was made optional.

lnjX commented 2 years ago

PR itself is ready, but just requires https://github.com/processone/xmpp/pull/65 to be merged (and tagged). :)

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.01%) to 33.459% when pulling 292e9454a52502025285ed5adec05c4c8af07c2b on JBBgameich:feature/mix-xmlns into d6b72f1c5dba891d6d1bb4a24bb297170b130a73 on processone:master.

badlop commented 2 years ago

PR itself is ready, but just requires processone/xmpp#65 to be merged (and tagged). :)

Usually those libraries are tagged only a few days before next ejabberd release...

The good news: you don't need to wait for it to be tagged: you can update rebar.config and mix.exs to use a recent commit.

A recent example usage: https://github.com/processone/ejabberd/commit/8f8de0403bab0a819420db69bb44bdb2a474d137

In this case, the ref would be "5b22f0c0ae189d0eda8ba469c0629041c1777857", which is the most recent xmpp commit.

lnjX commented 2 years ago

The good news: you don't need to wait for it to be tagged: you can update rebar.config and mix.exs to use a recent commit.

That's good to know! Changed it, so PR should be ready now. For mix.exs I had to set the specific git repo with override true, hope that's fine. :)