processone / ejabberd

Robust, Ubiquitous and Massively Scalable Messaging Platform (XMPP, MQTT, SIP Server)
https://www.process-one.net/en/ejabberd/
Other
6k stars 1.5k forks source link

Strange display / output of ejabberdctl (with Putty/windows, `$TERM=xterm` - underscores are on the whole line) #4151

Open sreutter opened 5 months ago

sreutter commented 5 months ago

Environment

Bug description

it's hard to read, and you can't see where there really has to be an underscore and where not. It's ok on wsl/debian ssh client.

Zwischenablage_01-19-2024_01

licaon-kter commented 5 months ago

Update to 23.10 :)

prefiks commented 5 months ago

I don't update will change how it's displayed. But i also don't think we are sending ansi sequence that would underline everything. Are you able to scroll up and see where that underline starts? is that after some command is printed or from the start?

badlop commented 5 months ago

Update to 23.10 :)

Text formatting in ejabberdctl output was added years ago f2bd87b7cfd1b9462d0d77dcfbaa44ac516bf581 and has no relevant changes since then; probably updating ejabberd is irrelevant in this case.

PuTTY Release 0.80 Build platform: 64-bit x86 Windows

I tried with Putty 0.80 on Debian, with default options: in that one text formatting works correctly. There are several options in Putty to disable terminal features, ANSI colours... but I haven't found anyone to disable text formatting. Maybe you can try some of the client options...

$TERM=xterm

No idea where to specify that in the Putty client.

licaon-kter commented 5 months ago

Was thinking about https://github.com/processone/ejabberd/pull/3979

badlop commented 5 months ago

@sreutter: As @licaon-kter noticed, this problem was fixed in ejabberd 23.04 thanks to commit https://github.com/processone/ejabberd/commit/648c83ea032831379b61624b6bcd3d743e4f94b9 proposed in https://github.com/processone/ejabberd/pull/3979

If I revert that fix and try with Putty on Debian, I can see the problem that you mentioned. Solution: update to ejabberd 23.04 or newer