Closed istoph closed 2 months ago
Nice finding! prosody2ejabberd didn't know how to handle the approved
attribute.
In fact, it is an optional attribute and it seems not implemented in ejabberd or the xmpp erlang library. The import code should be able to handle it, even if it does not store the content.
I've committed a fix for this problem, and also included a fix for previous code that forgot R. It seems to work great with your example.
Notice this commit is slightly different than your patch, because you were also fogetting R when handling approved
.
@badlop Thank you! I can confirm that your patch fixes the bug.
When I try to import a slightly larger instance of Prosody, I get some errors.
Environment
Erlang (SMP,ASYNC_THREADS) (BEAM) emulator version 13.1.5
Errors from cli:
ejabberdctl import_prosody "/var/lib/prosody/"
Example minimal reproducible:
/var/lib/prosody/5222%2ede/roster/user.dat
Bug description
The user user@5222.de will be import. He has entered admin@5222.de as a contact and is also countersigned with
["approved"] = "true"
.I have added the following roundtrip to line 325:
But it would make more sense to adopt this attribute as well.