search

processone / fast_tls

TLS / SSL OpenSSL-based native driver for Erlang / Elixir
https://www.ejabberd.im
Other
83 stars 37 forks source link

Make dialyzer happy #44

Closed NelsonVides closed 4 years ago

NelsonVides commented 4 years ago

There were three important errors. The first is on the spec for tcp_to_tls, which enforced the opts to be key-value pairs, but then we can obviously pass single atoms like connect, or compression_none. Then recv_and_loop said the last argument to be just an integer(), when it was supposed to be a timeout(). And last, erlang:load_nif/1 does not return anything like {error, already_loaded}.

The other changes are just for readability, specs had really strange indentation.

NelsonVides commented 4 years ago

@prefiks have you had a look at this PR and the other few I have open? Is there anyone else I could ask as well? 🙂