Make parameterizable the rebar binary

processone / fast_tls

TLS / SSL OpenSSL-based native driver for Erlang / Elixir

https://www.ejabberd.im

Other

83 stars 37 forks source link

Make parameterizable the rebar binary #51

Closed triaxx closed 3 years ago

triaxx commented 3 years ago

Define the REBAR variable by a conditional assignment doesn't change the behavior of this Makefile but allows a package manager to explicity set the full path of the rebar binary.

p1bot commented 3 years ago

Hi @triaxx, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

coveralls commented 3 years ago

Coverage remained the same at 62.194% when pulling 13a944c6889491236d1c30366b82272c0fecd46d on triaxx:master into 9b88fbec57ec8dae55269fba49fcbb54e974404d on processone:master.

p1bot commented 3 years ago

You did it @triaxx!

Thank you for signing the ProcessOne Contribution License Agreement.

We will have a look at your contribution!

badlop commented 3 years ago

Hi!

I guess this is useful for building it with rebar3.

And I guess this same change would be suggested for many other libraries which Makefile say explicitely "rebar", right now, right? I found: cache_tab, ezlib, fast_tls, fast_xml, fast_yaml, p1_utils, pkix, stringprep, stun, xmpp.

While checking, I noticed other libraries have it already parametrized, for example yconf https://github.com/processone/yconf/blob/aba6e0bb5d274482caf5447c77d71b50c9418026/Makefile#L1

REBAR=./rebar

Following the reasoning of this PR, I guess it would be preferable those assignments to be changed from "=" to "?=", right?

triaxx commented 3 years ago

Right!