search

processone / fast_tls

TLS / SSL OpenSSL-based native driver for Erlang / Elixir
https://www.ejabberd.im
Other
83 stars 37 forks source link

Support LibreSSL >= 3.5 (opaque structs) #53

Closed gramosg closed 2 years ago

gramosg commented 2 years ago

Hi,

This PR adds support for the next version of LibreSSL (3.5) that is scheduled for release on OpenBSD 7.1. This LibreSSL version adopts the struct visibility changes that were introduced in OpenSSL 1.1, and fast_tls fails to compile as it assumes the struct fields are still public.

With this change fast_tls builds successfully on the latest OpenBSD snapshot.

p1bot commented 2 years ago

Hi @gramosg, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

gramosg commented 2 years ago

Oh, nevermind, I didn't notice about the need to sign a CLA. As trivial as this change may be, CLAs are not compatible with my idea of contributing to open source so I'm not signing it. Sorry for the noise, have a good day.

Neustradamus commented 2 years ago

@gramosg: Have you looked the CLA? What is the problem? :/

gramosg commented 2 years ago

Hi @Neustradamus, the main problem IMO is that open source projects should be a relationship of equals, and that is not compatible with you keeping the right to relicense or even close the source of the project in the future, for example. I've glanced over your CLA but I'm no lawyer so I'm unable to tell whether it is or not your case. I also do not agree with forcing contributors to provide personal info, including full name, address and phone number, again, to contribute to an open source project. And finally, in this particular case, the CLA forces me to have to spend more time doing the paperwork than submitting the one-line patch, which I find quite annoying. Drew DeVault explains all of this a lot better in this article.

Anyway, I don't want to start a discussion over CLA ethics, just trying to briefly explain my point of view. Sorry for opening this PR, I wouldn't have done it if I knew about the CLA beforehand.

Neustradamus commented 2 years ago

@gramosg: I am only a contributor and I have signed the CLA, only suprised by your PR and the closing :/

badlop commented 2 years ago

Thanks for reporting the problem and explaining this simple solution!

I'll try to get my hands on a BSD system for testing this and the other libraries...

Let's consider this a bug report that also explains the solution, and I'll apply it acknowledging the person that initially reported it.

gramosg commented 2 years ago

@badlop I think that's perfect, thank you! I'll be happy to help if you need anything else related to this issue.