Update documentation to reflect the change from :stun_listener:add_listener/3 to add_listener/4

processone / stun

STUN and TURN library for Erlang / Elixir

http://www.ejabberd.im

Apache License 2.0

244 stars 62 forks source link

Update documentation to reflect the change from :stun_listener:add_listener/3 to add_listener/4 #30

Closed JesseHerrick closed 4 years ago

JesseHerrick commented 4 years ago

Hi all,

First, thank you for building such an awesome library. We make use of it here in https://github.com/littlelines/littlechat.

As I was upgrading the package, I noticed that the add_listener function now needs 4 parameters, with an IP as the first one. This was not reflected in the README so I have made that change in this PR.

Best, Jesse

p1bot commented 4 years ago

Hi @JesseHerrick, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

coveralls commented 4 years ago

Coverage remained the same at 55.06% when pulling 25b9da5788810ad8d53e7599ec69fd2ba179916f on JesseHerrick:jh-update-documentation-for-add-listener-ip into e53a1e8450ffadc8f4b4809a3fa9c903a5d9eeaf on processone:master.

p1bot commented 4 years ago

You did it @JesseHerrick!

Thank you for signing the ProcessOne Contribution License Agreement.

We will have a look at your contribution!

weiss commented 4 years ago

Thanks!