search

processone / xmpp

Erlang/Elixir XMPP parsing and serialization library on top of Fast XML
http://process-one.net
Apache License 2.0
137 stars 88 forks source link

Support XEP-0184: Message Delivery Receipts #20

Closed weiss closed 6 years ago

zinid commented 6 years ago

We should use records in result, otherwise encoding won't work (there is no way to know how to encode true or <<"id123">>). But if we don't need encoding, then it's fine.

zinid commented 6 years ago

Also, XEP-0184 support should be mentioned in README.

weiss commented 6 years ago

We should use records in result, otherwise encoding won't work (there is no way to know how to encode true or <<"id123">>). But if we don't need encoding, then it's fine.

Well I don't need encoding :smile:

I've seen you using true in many places and wasn't sure about the policy, but now I realized that you maybe used it only for elements that are just #referenced from other elements?

Also, XEP-0184 support should be mentioned in README.

Ah I keep forgetting that, sorry.

I force-pushed an update to fix these things.

zinid commented 6 years ago

Excellent Thanks a lot