search

processone / xmpp

Erlang/Elixir XMPP parsing and serialization library on top of Fast XML
http://process-one.net
Apache License 2.0
137 stars 88 forks source link

Allow fxml.hrl to be found from system libs. #3

Closed bowlofeggs closed 5 years ago

bowlofeggs commented 7 years ago

This commit adjusts an include() call to be include_lib() so that fxml.hrl can be found when it is installed in /usr/lib rather than in a local deps folder.

zinid commented 7 years ago

Wouldn't this break the "normal" building process? (i.e. git clone && configure && make)

bowlofeggs commented 7 years ago

@zinid It still seemed to build locally when I tried it out, but I would appreciate if you could test and make sure you agree.

manuel-rubio commented 7 years ago

Someone is going to merge this, please?

p1bot commented 5 years ago

Hi @bowlofeggs, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

bowlofeggs commented 5 years ago

@mremond I have similar thoughts on this one as I did in https://github.com/processone/ejabberd/pull/1446 - it's a pretty trivial change. If someone wanted to send this change who can agree to the CLA, I'd be good with that.

mremond commented 5 years ago

Thanks @bowlofeggs Yes, indeed it is a simple change. I guess it all get down to be able to imagine several build situation to make sure it does not break any specific build. Anyway, I will keep an issue open so that we keep this in mind.

Thanks !