Closed m-hennecke closed 1 year ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 93: | 0.0% |
Covered Lines: | 0 |
Relevant Lines: | 18707 |
Thank you
For architectures that have char defined as unsigned char comparing char with negative numbers will always be false. Use explicit signed char to fix this.
When building xmpp on a system running OpenBSD/aarch64 a lot of compiler errors show up like these:
or
Which makes sense, because the char type on OpenBSD/aarch64 architecture defaults to unsigned char. For architectures having char defined as signed this changes nothing function wise.