Update get-random-page.md

processwire-recipes / Recipes

Recipe Markdown files

29 stars 18 forks source link

Closed apeisa closed 9 years ago

apeisa commented 9 years ago

Old code had few problems:

$quote = $pages->find("parent=1041, include=hidden"); // example parent

using parent id is not nice for code readability
this loads all quotes - will lead into performance/memory problems when you got thousands of quotes

Also unnecessary to shuffle before getting random: $quote->shuffle(); $pick = $quote->getRandom();

apeisa commented 9 years ago

Done!

marcus-herrmann commented 9 years ago

:+1:

marcus-herrmann commented 9 years ago