Url field: When modifying a valid url, entering invalid characters will delete both the invalid and the original / valid url

[klor]

Short description of the issue

When using a url field on a page in the ProcessWire editing interface: When modifying a valid url, entering a url with invalid characters will delete both the invalid and the original / valid url

Expected behavior

• When entering a valid url, the url is saved (works)
• When modifying the valid url and entering invalid characters, then the "original, valid url" is restored (not deleted)

Actual behavior

This url is saved in my page:

As an editor, I modify the url (note the invalid Danish ø-character -> https://prøcesswire.com/)

Error message is shown - url is gone

On page refresh, the url is still gone

Optional: Suggestion for a possible fix

• When a valid url exists and the editor modifies the url using invalid characters, then keep the "original, valid url" (don't delete it)

Steps to reproduce the issue

1. Create template 'foo'
2. Add url field
3. Create page (use template 'foo')
4. Enter valid url: https://processwire.com/
5. Save page. Url field is now populated
6. Modify url: https://prøcesswire.com/
7. Save page
8. Refresh page (press CTRL+F5 on Windows). Url field is now empty.

Setup/Environment

• ProcessWire version: 3.0.210

[matjazpotocnik]

Ryan, it looks like if($error) $value = $this->val(); is missing at the and of setAttributeValue() in InputfieldURL.php ?

Klor, just for info, URL field allows IDN characters.

[ryancramerdesign]

Thanks @klor and @matjazpotocnik I've added matjazpotocnik suggested fix for this.

[matjazpotocnik]

@klor closing this, let me know if the fix isn't working for you.