processwire / processwire-issues

ProcessWire issue reports.
45 stars 2 forks source link

"Repeater item labels" setting not working #1729

Closed Toutouwai closed 1 year ago

Toutouwai commented 1 year ago

Short description of the issue

Setting:

2023-05-05_141659

Working in 3.0.214

2023-05-05_141647

Not working in 3.0.216

2023-05-05_141550

Setup/Environment

matjazpotocnik commented 1 year ago

Hm, I can't replicate here, it shows label as expected.

Toutouwai commented 1 year ago

@matjazpotocnik, do you have the dev version with the latest commits? I think the most recent commit broke this.

matjazpotocnik commented 1 year ago

Yes, you're right, now I can replicate. It's line 158 $repeaterTitle = preg_replace('/#([a-f\d]{3,})/i', "$colorPrefix$1", $out); Perhaps $out should be $repeaterTitle?

ryancramerdesign commented 1 year ago

@Toutouwai @matjazpotocnik Looks like you are right, that $out should be a $repeaterTitle, thanks :)