search

processwire / processwire-requests

ProcessWire feature requests.
40 stars 0 forks source link

Trash restore icon is trashcan #289

Open ghost opened 5 years ago

ghost commented 5 years ago

@adrianbj commented on Oct 23, 2017, 4:35 PM UTC:

Short description of the issue

Trash restore icon is trashcan

Expected behavior

I think it should be a different icon because this suggests deleting, not restoring.

Optional: Screenshots/Links that demonstrate the issue

screen shot 2017-10-23 at 9 35 00 am

This issue was moved by netcarver from processwire/processwire-issues#412.

ghost commented 5 years ago

@szabeszg commented on Oct 23, 2017, 5:51 PM UTC:

suggestions:

ghost commented 5 years ago

@matjazpotocnik commented on Oct 23, 2017, 6:04 PM UTC:

Or no icon at all. Just Trash/Restore.

ghost commented 5 years ago

@szabeszg commented on Oct 23, 2017, 6:11 PM UTC:

It is an important action so I support keeping it prominent by using an icon it's just the trashcan which is misleading a bit.

ghost commented 5 years ago

@matjazpotocnik commented on Oct 23, 2017, 6:13 PM UTC:

Are you saying that other actions are not important? :-)

ghost commented 5 years ago

@szabeszg commented on Oct 23, 2017, 6:16 PM UTC:

I mean under Admin > Trash, that is where you can undo the trashing operation, it is good to be able to spot this one easily.

ghost commented 5 years ago

@teppokoivula commented on Oct 24, 2017, 3:45 AM UTC:

Are you saying that other actions are not important? :-)

It's not more important, but it is different. It's the only action that I'd describe as "destructive", so definitely worth making it stand out.

ghost commented 5 years ago

@matjazpotocnik commented on Oct 24, 2017, 5:29 AM UTC:

You can restore from trash, so trash is not that destructive, or is it? If trash action is destructive, is restore action also destructive? Is unpublish action destructive? It might be, because you are potentially "removing" the content form the site. But that action can be reversed easily. Is save action destructive? Well, it could be, since there is no easy way of reversing the content of page. I'm not against the trash/restore icon, just thinking out loud. And of course, trashbin icon is inappropriate for restore action, no doubt about that.

ghost commented 5 years ago

@teppokoivula commented on Oct 24, 2017, 3:11 PM UTC:

Good points :)

I see trash as a more destructive action mainly because restoring a page is somewhat more tedious than, say, publishing a page that was accidentally unpublished. Page "disappears" into trash, and it can take a while to relocate it. Restoring trashed pages is also out of bounds for non-superusers, but then again I believe the page tree action is also (unless somehow overridden).

ghost commented 5 years ago

@ryancramerdesign commented on Nov 2, 2017, 2:04 PM UTC:

I don't think the Restore button is clear enough without the trash icon, because then it's just "Restore", and what does that mean? The label could be "Trash Restore" or "Restore from Trash", but I think that's just too long. If font-awesome had a trash-slash or trash-arrow-up icon, no doubt it would be preferable. But there isn't anything like that. Another option might be a different label using a made-up word "untrash".

ghost commented 5 years ago

@teppokoivula commented on Nov 2, 2017, 2:23 PM UTC:

Just dropping this here in case someone wants to add their vote: FortAwesome/Font-Awesome#4090.

ghost commented 5 years ago

@matjazpotocnik commented on Nov 2, 2017, 4:28 PM UTC:

because then it's just "Restore", and what does that mean? The label could be "Trash Restore" or "Restore from Trash",

Since we are already in Trash, there is no need for words "...from Trash". Also it would be too long. But I think we have more important issues to deal with so the best option right now, as I see it, is that we wait for un-trash icon.

ghost commented 5 years ago

@adrianbj commented on Nov 2, 2017, 4:38 PM UTC:

Since we are already in Trash, there is no need for words "...from Trash".

I completely agree - you're in the trash section - if you can't figure out what "restore" means, there's a problem :)

I don't honestly see the problem with using the reply icon and keeping the "Restore" text just as it is. Yes, the proposed new icon that teppokoivula linked to would be better, but for now I think reply would be fine.

But, I also agree that this isn't a huge deal - I never expected so much conversation on it.

ghost commented 5 years ago

@matjazpotocnik commented on Feb 28, 2018, 9:15 AM UTC:

Works with fa-stack: FortAwesome/Font-Awesome#4090 (comment) Demo: https://codepen.io/fxmt/pen/vdvdKy

ghost commented 5 years ago

@adrianbj commented on Jan 29, 2019, 1:23 PM UTC:

FontAwesome now has a free trash restore icon: https://fontawesome.com/icons?d=gallery&q=trash-restore&m=free

ryancramerdesign - any chance of a FA upgrade and including this new icon?

ghost commented 5 years ago

@netcarver commented on Mar 22, 2019, 12:49 PM UTC:

ryancramerdesign Bumping for your consideration.

ghost commented 5 years ago

@ryancramerdesign commented on Mar 26, 2019, 12:34 PM UTC:

netcarver adrianbj I think the previous two mentioned options above both require Font Awesome 5.x, which is not compatible with version 4.7 that we are using. Actually 5.x is like a different product, using different icon names in many cases and requiring different class names. Looks like a painful upgrade, short of applying a compatibility hack on top of it. When we upgrade to it, it'll likely be tied to a major PW version.

ghost commented 5 years ago

@netcarver commented on Mar 26, 2019, 12:42 PM UTC:

Ok, I'll transfer this to the requests repo in that case.