search

processwire / processwire-requests

ProcessWire feature requests.
39 stars 0 forks source link

Please make the processCSV method hookable #436

Closed juergenweb closed 2 years ago

juergenweb commented 2 years ago

Short description of the enhancement

It would be great if you will add the 3 uncerscores to the processCSV method of the ProcessLanguage class. This method is not hookable by default at the moment.

Optional: Steps that explain the enhancement

In my case need to hook this method to add translations to fields created by a module (Take a look at the blog post at https://processwire.com/talk/topic/26765-module-translations-hooking-after-translation-csv-file-was-imported-and-saved/#comment-221611

You only have to add 3 underscores and nothing more. ;-)

ryancramerdesign commented 2 years ago

No problem, I will make sure it is hookable in the next dev branch version 3.0.195. If you'd like feel free to add the 3 underscores to your copy and it'll be present on the next update.

On Mon, Feb 14, 2022 at 4:59 PM juergenweb @.***> wrote:

Short description of the enhancement

It would be great if you will add the 3 uncerscores to the processCSV method of the ProcessLanguage class https://github.com/processwire/processwire/blob/master/wire/modules/LanguageSupport/ProcessLanguage.module. This method is not hookable by default at the moment. Optional: Steps that explain the enhancement

In my case need to hook this method to add translations to fields created by a module (Take a look at the blog post at https://processwire.com/talk/topic/26765-module-translations-hooking-after-translation-csv-file-was-imported-and-saved/#comment-221611 https://processwire.com/talk/topic/26765-module-translations-hooking-after-translation-csv-file-was-imported-and-saved/#comment-221611l

You only have to add 3 underscores and nothing more. ;-)

— Reply to this email directly, view it on GitHub https://github.com/processwire/processwire-requests/issues/436, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACQEUGBLO5HTP4EV7SRAPDU3F3LFANCNFSM5OMWLITA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

juergenweb commented 2 years ago

Thank you!!!!