automatically call the init method on custom page classes

[jmartsch]

Custom Page classes are great, but they would be even greater if we could use hooks in their init method which would be called automatically.

One thing I and others like Bernhard are doing when developing custom modules (or modifying ProcessPageEdit pages), is to add hooks to a custom page class like so:

<?php namespace ProcessWire;
// site/classes/OrderPage.php
class OrderPage extends Page{
  public function init(){
    bd("init OrderPage");
    bd($this->template->name);
    $this->addHookBefore('ProcessPageEdit::buildFormContent', $this, "buildFormContent");
  }

  public function buildFormContent($event){
    bd("buildFormContent");
    // modify the form before output
  }
}

However the init method isn't called when you go to a page with the order template (in my case in the admin).

Bernhard has a workaround where he triggers the init method of the custom page class in /site/init.php via $pages->get('template=order')->init();;

Problems with this approach are:

• The init method would be called always, regardless if you are on a page with the template "order".
• adds overhead as it has unnessesary calls
• it prevents using a buildFormContent method which is different on every custom page class. For example on one template I want to use the buildFormContent method to add a field to the form, on another template I want to add a tab.

If I want to use the workaround Bernhard provided, I would have to return early manually if the template name doesn't match, like so:

public function buildFormContent(HookEvent $event)
  {
    // Change the title of the page and the browser tab
    // Get page being edited
    $page = $event->object->getPage();
    // Only use on pages with the order template
     if ($page->template != 'order') return;

   // else do stuff
  }

Else the hook would be executed on every page.

What you think about this, or are there other ways, to modify things like the form content in the admin via custom page classes?

[BernhardBaumrock]

You can do this:

<?php namespace ProcessWire;
use RockMigrations\MagicPage;
class OrderPage extends Page {
  use MagicPage;

  public function editForm($form) {
    $form->get('title')->label = 'hooked label';
  }
}

;)

See https://github.com/baumrock/RockMigrations/blob/1312656a459a723510019f9a3e1d95b550b3625a/RockMigrations.module.php#L506

[jmartsch]

@BernhardBaumrock This requires installing your RockMigrations module. I would prefer to have this natively and not via an additional module. But thank you for showing me this solution, which I think I will use until we have something better.

[ryancramerdesign]

@jmartsch How about using the wired() method? I think it should do the same thing as an init() method in this case. It is called for any Wire-derived class when the current ProcessWire instance dependency injection is complete. Of course, you could use the construct() method too, but at that point the current instance dependencies have not been injected, so construct() is not an ideal method for adding hooks.

[jmartsch]

Thanks for your answer @ryancramerdesign. I didn't know about the wired() method. Using it works absolutely fine.

[BernhardBaumrock]

@ryancramerdesign and @jmartsch using wired() might have unexpected side effects! For example if you create a "BasicPagePage" pageclass and add the wired() method, than this wired() method is called for every loaded BasicPage. So if you had 3 BasicPages in your pagetree, then that triggers wired() three times!

Depending on your implementation of wire() this might add your hook more often than you want...

RockMigrations makes sure that for MagicPages the init() method is triggered on "init" of the boot process and "ready" at ready. And both are triggered only ONCE no matter how many pages you have created (with the latest version also if no page is created!).

It does also offer other helper methods like "onSaveReady", which is only triggered on saveReady of this specific pageclass! So you get extremely simple and clean code, see https://www.youtube.com/watch?v=eBOB8dZvRN4&t=517s

[jmartsch]

I experienced something similar to what @BernhardBaumrock mentioned. I use AdminOnSteroids, which adds a prev and next Button to a ProcessPageEdit page. As the prev and next Button query the PW API, it executes the hook for all pages which have the type OrderPage.
In my hook I add a field (or more) to the ProcessPageEdit form. So I had three fields added, instead of one.

It would be nice, if there is a native way of doing what Bernhad mentioned. So that the hook only gets added once.

[teppokoivula]

It would be nice, if there is a native way of doing what Bernhad mentioned. So that the hook only gets added once.

I get that you're perhaps looking for a "ProcessWire native" way to do this, but just for the record: this should be quite easy to avoid by using static class property in your OrderPage class. Store the hook ID returned by addHook there, and only add the hook if that property is empty.

Sure, that adds a bit of boilerplate, but we're talking about a couple of lines of code here. I guess it's a question of point of view if we need something in the core for this :)

[szabeszg]

Bernhad and I recently discussed the same topic, see: https://processwire.com/talk/topic/27419-processwirerocks-my-youtube-channel-%F0%9F%98%8E/?do=findComment&comment=226313

I also used to ask Ryan about a related issue, namely how to handle a frontend page request via a Custom Page method (LoginRegisterPro module topic) module: https://processwire.com/talk/topic/23310-register-link-not-correct/?do=findComment&comment=223150

What I would really like to see is core support for both needs, because initialising a page object at the right time in the page request process is a must. We can agree on that, I think.

It's great that we have the basics and it is documented: https://processwire.com/blog/posts/pw-3.0.152/ but the next step should be official support to make the initialisation process simple and documented too. I wish... :)

[jmartsch]

@ryancramerdesign Any further thoughts on this? I think a native way of triggering the init or ready method at the right time would be a huge improvement to what i doable with ProcessWire as a software framework.

[jlahijani]

@ryancramerdesign 🙏

[szabeszg]

@ryancramerdesign 🙏

As far as I know, Ryan checks the number of "thumbs up" of the initial post of the request. Anyone want to add more?

[BernhardBaumrock]

Hey @ryancramerdesign I still think this would be a great addition! Others try to find a solution for this as well, see See https://processwire.com/talk/topic/29996-a-simple-way-to-have-your-hook-methods-inside-your-custom-page-classes/

I think it would already be enough to trigger init() and ready() properly. No need (impossible) to reflect all hookable methods like buildform or saveready, we could do that on our own, but we'd need at least the ready() and init() method to attach the needed hooks and have everything related to the custom page class inside the custom page class.

This is how RockMigrations is doing it, which works great for years now: https://github.com/baumrock/RockMigrations/blob/5d7bb4b427f953bf79257c332bd9dcfbd8bba261/MagicPages.module.php#L90-L91