search

proco-ontology / PROCO

PROCO: A formal ontology in the domain of process chemistry
9 stars 2 forks source link

bulk substance quality issue #3

Closed schaferw closed 2 years ago

schaferw commented 2 years ago

The issues @pbuttigieg brought up seem to have been fixed, thanks, but I note some cryptic incoherencies e.g. bulk substance quality is a subclass of quality and ICE. Is this deliberate? You use a name that is consistent with PATO qualities but your intention seems to be to shadow a quality with an ICE. You can't be blamed for this as OBO practice is poor here, but I think if you really want to model it as an ICE, call it "bulk substance quality datum" or something (the practice of shadowing characteristics with ICEs is bad but I have not yet convinced everyone in OBO of this)

See: https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1487#issuecomment-1020668279

schaferw commented 2 years ago

adjusted the subclass to: 'inheres in' some 'portion of material' instead of 'is about' some 'portion of material'