search

procore-oss / backstage-plugin-announcements

Announcements Plugin for Backstage
https://procore-oss.github.io/backstage-plugin-announcements/
MIT License
27 stars 20 forks source link

🚀 Feature: Take signals into use #193

Open drodil opened 7 months ago

drodil commented 7 months ago

🔖 Feature description

The signals plugin is coming in the Backstage 1.23.0 release. This allows to send push messages from backend to frontend plugins. Announcements plugin could also utilize this to show new announcements without need for polling or user to refresh the page.

🎤 Context

See backend integration: https://github.com/backstage/backstage/blob/master/plugins/signals-node/README.md And frontend: https://github.com/backstage/backstage/blob/master/plugins/signals-react/README.md

✌️ Possible Implementation

  1. Create signal announcements and publish to that whenever there is new announcement created
  2. In the frontend use useSignal('announcements') to get info about the changes
  3. When the signal is received, re-fetch and re-render the announcements

👀 Have you spent some time to check if this feature request has been raised before?

Are you willing to submit PR?

None

gaelgoth commented 4 months ago

@drodil I just read your medium post about Backstage notification, I think that announcements plugin is good candidate for using NotificationService

kurtaking commented 4 months ago

@gaelgoth, there is a bit more context around the use of signals in this discord thread.

I've also been thinking about ways the notifications plugins may make the announcements plugins obsolete. We could contribute a few components that render the output of the broadcast feature to announcement-styled components.

So users would receive a notification, but you could also broadcast as an announcement. Something along those lines.

jjwedemyer commented 2 months ago

I've also been thinking about ways the notifications plugins may make the announcements plugins obsolete. We could contribute a few components that render the output of the broadcast feature to announcement-styled components.

So users would receive a notification, but you could also broadcast as an announcement. Something along those lines.

Hi @kurtaking,

did you come to any conclusion regarding this integration? We would like to integrate announcements into our dev portal (with a possibility to notify with external tools like mattermost). In that matter we could contribute here to either an integration or the "announcement" components.

kurtaking commented 2 months ago

I've also been thinking about ways the notifications plugins may make the announcements plugins obsolete. We could contribute a few components that render the output of the broadcast feature to announcement-styled components. So users would receive a notification, but you could also broadcast as an announcement. Something along those lines.

Hi @kurtaking,

did you come to any conclusion regarding this integration? We would like to integrate announcements into our dev portal (with a possibility to notify with external tools like mattermost). In that matter we could contribute here to either an integration or the "announcement" components.

I haven't had the time lately to think through this. Others have asked for similar functionality to what you want, so the change is definitely welcome.