Feature: Discard nil value field

procore-oss / blueprinter

Simple, Fast, and Declarative Serialization Library for Ruby

MIT License

1.14k stars 109 forks source link

Feature: Discard nil value field #425

Closed jamesst20 closed 4 months ago

jamesst20 commented 5 months ago

Closes https://github.com/procore-oss/blueprinter/issues/424

Checklist:

[OK] I have updated the necessary documentation
[OK] I have signed off all my commits as required by DCO
[OK] My build is green

jamesst20 commented 5 months ago

Thank you for opening this and helping add some additional configurability to Blueprinter!

Most of my comments are primarily around naming, but happy to discuss further!

Thanks for the quick review! Very much appreciated. I have applied all of your recommandations, after all I don't know much about this project conventions so I will stick to yours :)

jamesst20 commented 4 months ago

Hey @lessthanjacob

May I kindly bump this and ask what's the next step now that is has your approval?

lessthanjacob commented 4 months ago

Hey @jamesst20! I believe I may have suggested some changes to the tests that weren't totally valid syntax-wise. Do you mind addressing those locally and pushing up a fix? Apologies for that!

jamesst20 commented 4 months ago

@lessthanjacob It's done! :) Indeed there was an extra , at the end of a line

Capture d’écran, le 2024-07-10 à 11 05 26