Set job to failed when task raises and job is aborting (regardless retry)

[medihack]

Closes #1131

Successful PR Checklist:

• [x] Tests
  • [ ] (not applicable?)
• [ ] Documentation
  • [ ] (not applicable?)

PR label(s):

• [ ] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20breaking%20%F0%9F%92%A5
• [ ] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20feature%20%E2%AD%90%EF%B8%8F
• [x] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20bugfix%20%F0%9F%95%B5%EF%B8%8F
• [ ] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20miscellaneous%20%F0%9F%91%BE
• [ ] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20dependencies%20%F0%9F%A4%96
• [ ] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20documentation%20%F0%9F%93%9A

This time, a job with the status aborting of a task that raises is set to failed (regardless of whether it should be retried or not). It feels a bit more consistent to me, but somehow, there is no optimal way. If we set a to-be-retried job in status aborting to aborted when the task raises, but one to failed that should not be retried, it seems somehow inconsistent to me.

@ewjoachim A note in the documentation is still missing. Just want to hear what you think.

[github-actions[bot]]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
procrastinate
worker.py
Project Total

This report was generated by python-coverage-comment-action

[medihack]

That's great! I believe there may be a bit of conflict when we merge the worker refactor, though.

@onlyann When I commit this (later today), can you include it in the worker refactoring?

Thank you so much for the time you spent and doing it all over again after my comment!

No prob, the comment was very relevant. And I am happy that we don't need a migration 🙂.

[onlyann]

That's not a problem, I will resolve the conflict.

I think it's fine to merge this fix but wanted to highlight that there can still be a race condition where the job is changed to "aborting" between the check and the moment the job is set to retry.

Something we can look at improving if we end up removing that extra status in v3

[medihack]

Alright, I will write a note in the documentation, merge it, and make a patch release.

[ewjoachim]

:+1: