Reconsider the "aborting" status

procrastinate-org / procrastinate

PostgreSQL-based Task Queue for Python

https://procrastinate.readthedocs.io/

MIT License

840 stars 52 forks source link

Reconsider the "aborting" status #1136

Closed medihack closed 1 month ago

medihack commented 1 month ago

It would be simpler if we had a dedicated field for an abortion request instead of an aborting status.

The aborting state masks the doing state. State transitions from aborting are the same as from doing.
Also, since the user does not necessarily have to follow this request with a dedicated field, it would still be preserved in a subsequent possible retry.
Race conditions may occur that could solved with a dedicated field.

medihack commented 1 month ago

I already started working on a PR.

I added a boolean abort column to the jobs table. The migration will change all aborting states to doing states and set the abort to true. One principle question: Should we keep the abort as true when the job is finished, or should we reset it to false? Does it matter somehow?

ewjoachim commented 1 month ago

Should we keep the abort as true when the job is finished, or should we reset it to false? Does it matter somehow?

(As long as the job is not retried, I don't have a strong opinion)

ewjoachim commented 1 month ago

Fixed by #1139