procrastinate-org / procrastinate

PostgreSQL-based Task Queue for Python
https://procrastinate.readthedocs.io/
MIT License
840 stars 52 forks source link

Fix Django + cron using the wrong connector #1164

Closed ewjoachim closed 3 weeks ago

ewjoachim commented 3 weeks ago

Closes #1158

We should not use with_connector. replace_connector is the way to go. with_connector has been documented for ages so there's no hurry to remove it, but at least now, it's clear.

I'll need to think about whether this is testable but I'm really not sure.

This PR makes it so that we (almost) don't use with_connectors anymore.

Successful PR Checklist:

PR label(s):

github-actions[bot] commented 3 weeks ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  procrastinate
  app.py
  procrastinate/contrib/django/management/commands
  procrastinate.py
Project Total  

This report was generated by python-coverage-comment-action