procxx / kepka

Unofficial Telegram Desktop messaging app
https://procxx.github.io
Other
114 stars 29 forks source link

Rtl fix #156

Closed Randl closed 6 years ago

Randl commented 6 years ago

It should close #103

(edited by @leha-bot for GH Automation)

ForNeVeR commented 6 years ago

Maybe squash these?

leha-bot commented 6 years ago

We should test it with files containing this RTL character \u202E Seems that this is the one filtered character (see here: https://github.com/procxx/kepka/pull/156/files#diff-cf9b0949b8b74d47a3e0eb58d799229eR1681 )

Randl commented 6 years ago

https://www.openssl.org/docs/man1.1.0/crypto/ERR_remove_state.html

On Mon, Jun 4, 2018, 18:44 Alex notifications@github.com wrote:

@leha-bot commented on this pull request.

In Telegram/SourceFiles/core/utils.cpp https://github.com/procxx/kepka/pull/156#discussion_r192788132:

@@ -317,9 +317,9 @@ namespace ThirdParty { // FIPS_mode_set(0); ENGINE_cleanup(); CONF_modules_unload(1);

  • ERR_remove_state(0);
  • ERR_remove_state(0); // TODO(Randl): deprecated in 1.0.0

Could you share a proof of this statement?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/procxx/kepka/pull/156#pullrequestreview-125631381, or mute the thread https://github.com/notifications/unsubscribe-auth/AC42PxEfOCUSzTpJyk7FrnmLvINBPhdxks5t5VXkgaJpZM4UZUPg .

crackedmind commented 6 years ago

:white_check_mark: Build kepka 1.0.130-ntavlaaq completed (commit https://github.com/procxx/kepka/commit/687eec0a23 by @Randl)

crackedmind commented 6 years ago

:white_check_mark: Build kepka 1.0.130-jwpelarq completed (commit https://github.com/procxx/kepka/commit/79f8a0725a by @Randl)

crackedmind commented 6 years ago

:white_check_mark: Build kepka 1.0.132-gycbiupe completed (commit https://github.com/procxx/kepka/commit/36bf69ed27 by @Randl)