search

procxx / kepka

Unofficial Telegram Desktop messaging app
https://procxx.github.io
Other
114 stars 29 forks source link

Fix warnings #42

Open leha-bot opened 6 years ago

leha-bot commented 6 years ago

Currently, we have a ton of warnings. On some distros it interprets like errors. We need to fix these warnings.

Some warnings are simple and could be fixed automatically with brand new C++17 features like [[maybe-unused]], [[fallthrough]], some warnings related to Qt/stdint types collision (see bug #18 , for example).

Links to warning-prone lines are welcomed in comments.

berkus commented 6 years ago 
# Ones that need to be fixed:
set_flag_if_supported(Telegram WNMFI  -Wno-missing-field-initializers)
set_flag_if_supported(Telegram WNSC   -Wno-sign-compare)
set_flag_if_supported(Telegram WNUP   -Wno-unused-parameter)
set_flag_if_supported(Telegram WNUV   -Wno-unused-variable)
set_flag_if_supported(Telegram WNUF   -Wno-unused-function)
set_flag_if_supported(Telegram WNS    -Wno-switch)

These are the classes of warnings that happen in the sources - you could enable them one-by-one and fix them off.