search

procxx / kepka

Unofficial Telegram Desktop messaging app
https://procxx.github.io
Other
114 stars 29 forks source link

[Mac OS] add support native OpenAl for mac os #85

Closed pperehozhih closed 6 years ago

pperehozhih commented 6 years ago

[Mac OS] add support native OpenAl for mac os (need add cmake arg PROCXX_USE_NATIVE_OPEN_AL)

crackedmind commented 6 years ago

:white_check_mark: Build kepka 1.0.57-fclmtcst completed (commit https://github.com/procxx/kepka/commit/2bc2cc55e1 by @pperehozhih)

crackedmind commented 6 years ago

:white_check_mark: Build kepka 1.0.59-yhoimuro completed (commit https://github.com/procxx/kepka/commit/d16c41963c by @pperehozhih)

berkus commented 6 years ago

Based on the discussion and usage of ALC_CONNECTED in Kepka sources (which is not supported by MacOS OpenAL) I am not sure this PR can be merged as-is - it will probably break device disconnection scenarios.

The only reason proposed for this PR is "less dependencies" but on mac brew install openal-soft is the simplest method to obtain the dependency so I don't see it as a problem. Conan packages also have some openal-soft builds.

Links related to discussion:

berkus commented 6 years ago

Lets close this for now, as there seem to be no acceptable changes to do.