search

procxx / kepka

Unofficial Telegram Desktop messaging app
https://procxx.github.io
Other
114 stars 29 forks source link

Move out hardcoded urls to constants #99

Closed leha-bot closed 6 years ago

leha-bot commented 6 years ago

Related to #20

leha-bot commented 6 years ago

I need your ideas about where we will move that constants.

leha-bot commented 6 years ago

Also we should reuse the messengerChangeLogUrl at this place: https://github.com/procxx/kepka/blob/dc231f2e2954876d47f5ab8066f26590a22841bf/Telegram/SourceFiles/boxes/about_box.cpp#L64

crackedmind commented 6 years ago

:x: Build kepka 1.0.67-kdapjuyu failed (commit https://github.com/procxx/kepka/commit/55dbad394a by @leha-bot)

leha-bot commented 6 years ago

@crackedmind shrug good night for me

leha-bot commented 6 years ago

We decide to use the additional lang files with messenger metainfo.

https://github.com/procxx/kepka/blob/dev/Telegram/Resources/qrc/telegram.qrc

crackedmind commented 6 years ago

:x: Build kepka 1.0.71-axqowear failed (commit https://github.com/procxx/kepka/commit/4f0200c30d by @leha-bot)

crackedmind commented 6 years ago

:x: Build kepka 1.0.71-tvhclsra failed (commit https://github.com/procxx/kepka/commit/e57f0772be by @leha-bot)

crackedmind commented 6 years ago

:x: Build kepka 1.0.71-ubngivsm failed (commit https://github.com/procxx/kepka/commit/d593bcda71 by @leha-bot)

leha-bot commented 6 years ago

It seems that the lang codegen does not support multiple .lang files. I think that we should create a CMake-based solution which will append our metainfo lang strings to vanilla .lang file

crackedmind commented 6 years ago

:white_check_mark: Build kepka 1.0.71-pcascqik completed (commit https://github.com/procxx/kepka/commit/e2a5a308a6 by @leha-bot)

crackedmind commented 6 years ago

:white_check_mark: Build kepka 1.0.71-igiclfdt completed (commit https://github.com/procxx/kepka/commit/f432bd775b by @leha-bot)