search

procyon-rs / vega_lite_4.rs

rust api for vega-lite v4
Apache License 2.0
26 stars 7 forks source link

Vega Lite 5 #23

Closed krokosik closed 1 year ago

krokosik commented 2 years ago

Hi!

I am considering creating a similar crate for Vega Lite 5, mostly for my personal usage, but will of course share it if I succeed. I noticed that the approach you took in creating this crate, was to copy the vega_lite_3, regenerate the schema and then update the API. I am willing to do that for VL5, however I'm quite new to Rust and currently working on my first project for personal use (for which I need interactive graphs), so I'd like to ask you, how much effort would you say it took you to create this crate and more importantly do you have anything against me using yours?

Cheers

ThomAub commented 2 years ago

Yes this crate is mostly auto generated so it should not be too much to try for V5. We use some script to download the schema specification and with some sed magic we try to improve the rust API with more friendly types. Then we update the different examples. Feel free to do the same and we can add it here or have a link to your version of the V5 specification.

krokosik commented 2 years ago

Yeah, the script is amazing, so simple and so cool, tremendous work! However, I am still in the research phase in my project and wanted to first develop a React version of my frontend and then migrate to Yew, so I guess I'll wait until then with making a VL5 crate

ptiza commented 1 year ago

I created vega_lite_5.rs So far it runs fine, at least with all the examples. I also opened #26 however, this should rather be a separate crate, so how to proceed best?

ThomAub commented 1 year ago

I will create the repo for the crate as a copy of this current repo. This should allow you to apply the same changes you have on you current branch. If this this ok with you I will find some time to do it this week ?

ptiza commented 1 year ago

I will create the repo for the crate as a copy of this current repo. This should allow you to apply the same changes you have on you current branch. If this this ok with you I will find some time to do it this week ?

Sure, fine for me! Thanks

davidB commented 1 year ago

@ptiza Can you remade your PR on https://github.com/procyon-rs/vega_lite_5.rs, Please ?

ptiza commented 1 year ago

Opened https://github.com/procyon-rs/vega_lite_5.rs/pull/1

davidB commented 1 year ago

released on crates.io https://crates.io/crates/vega_lite_5

Thank you @ptiza

RalfNorthman commented 1 year ago

Nice!

I noticed the repository link on crates.io goes to vega_lite_4.

EDIT: Opened a PR: https://github.com/procyon-rs/vega_lite_5.rs/pull/2