search

prodis / miss-elixir

Some functions that I miss in Elixir standard library (and maybe you too).
Apache License 2.0
42 stars 4 forks source link

Ensure module logo has transparent background #1

Closed kianmeng closed 3 years ago

kianmeng commented 3 years ago

While the contributing guide forbids contributor from changing the mix.exs file, I believe this is an exception case.

This PR adds transparency to the module logo.

Before. image

After. image

After (latest). image

prodis commented 3 years ago

@kianmeng Thanks for your PR.

The label "MISS" in the bottleneck should not be transparent.

kianmeng commented 3 years ago

@kianmeng Thanks for your PR.

The label "MISS" in the bottleneck should not be transparent.

Got it.

image

kianmeng commented 3 years ago

Fixed.

Original. https://github.com/kianmeng/miss-elixir/blob/make-logo-bg-transparent/assets/miss-elixir-logo.jpg

With transparency. https://github.com/kianmeng/miss-elixir/blob/make-logo-bg-transparent/assets/miss-elixir-logo.png