prodo-dev / prodo

Prodo is a React framework to build apps faster.
https://docs.prodo.dev
MIT License
114 stars 5 forks source link

Model diagram in Getting started section #123

Open sunirmehta opened 5 years ago

sunirmehta commented 5 years ago

image

tdawes commented 5 years ago

Is there any reason that the diagram is a triangular rather than a diamond/circle? It feels like it's suggesting that model -> store -> view is someone "more linear" than view -> action -> model

tdawes commented 5 years ago

Also perhaps we should change updates to patches to bring it inline with some of the dev tools - not sure if that's clear enough though.

sunirmehta commented 5 years ago

Does this look better? Will add to docs and raise PR if it does.

model diagram rework

tdawes commented 5 years ago

Yeah looks better to me. Still not sure whether "updates" is better than "patches" - what do you think?

We should also change init to createStore.

It might also be better to make sure it's obvious that the important "cycle" is store -> view -> action -> store, i.e.

                    /--(render)--> view
                   /                 |
model --(init)-> store           (dispatch)
                   ^                 V
                    \--(patches)-- action

I'm also a little unsure that we're being clear enough:

This is an example of how redux is sometimes explained:

andrejak commented 5 years ago

@tdawes @sunirmehta is this resolved?

sunirmehta commented 5 years ago

Some progress here: (model draft.jpg) Also did some reading on using the word "update" over "patch. UPDATE seems to make more sense : (patchvsupdate.jpg)

Will need someone to sense check everything
model_draft4 patch vs update

andrejak commented 5 years ago

Mostly looks good to me, except I think you want the dispatch arrow to be the other way around. But probably need @tdawes to confirm. It would be worth adding this soon given one of our users has already expressed confusion about the model, and maybe this would help at least a little bit.