prodot / ReCommended-Extension

Code analysis improvements and context actions
Apache License 2.0
59 stars 11 forks source link

Delete 'Annotate with [ItemCanBeNull/ItemNotNull]' quick action #20

Closed zvirja closed 4 years ago

zvirja commented 8 years ago

Starting R# 2016.2 there are built-in quick actions to arrange [ItemNotNull]/`[ItemCanBeNull]' attributes. Therefore, currently, there are duplicates in menu:

image

Moreover, R# supports both attributes, while plugin provides a half only.

michael-damatov commented 8 years ago

R# 2016.2 still doesn't support async methods where task result is a reference type: async Task<string> MethodAsync() => null; // [ItemNotNull] must be suggested.

Removing the quick action would reduce the functionality.

michael-damatov commented 4 years ago

The upcoming release 4.0 does not suggest to annotate with [ItemNotNull] if the nullable annotation context is enabled (C# 8.0).