search

prodot / ReCommended-Extension

Code analysis improvements and context actions
Apache License 2.0
59 stars 11 forks source link

Fix 20: Remove ItemCanBeNull annotation action #24

Closed zvirja closed 7 years ago

zvirja commented 8 years ago

Annotation action is already present in latest version of R#. There is no need to duplicate it.

michael-damatov commented 8 years ago

R# 2016.2 still doesn't support async methods where task result is a reference type: async Task<string> MethodAsync() => null; // [ItemNotNull] must be suggested.

Removing the quick action would reduce the functionality.

zvirja commented 8 years ago

Indeed! Missed that. In this case, should we just reduce functionality of your plugin to support that particular case only? Do you know about other cases that are not covered?

Also, I'd say that position should be exactly the same as it's for the build-in Item not null action.

zvirja commented 8 years ago

It was my miss. Actually, R# has this functionality, see demo: nullabilitydemo

Am I missing something?

zvirja commented 7 years ago

@michael-damatov Any updates on this one? If you don't have time for these discussions - let me know and I'll just close this PR ;-)