search

product-definition-center / pdc-ruby-gem

PDC Ruby Gem
MIT License
1 stars 7 forks source link

Fix some existing pronto errors #36

Closed simozhan closed 6 years ago

simozhan commented 6 years ago

Fix some pronto errors like:

  1. examples/local_pdc_dev.rb:15:9: C: Style/YodaCondition: Reverse the order of the operands FILE == $PROGRAM_NAME. (https://en.wikipedia.org/wiki/Yoda_conditions) main if FILE == $PROGRAM_NAME

  2. examples/logger.rb:8:3: C: Style/EmptyMethod: Put empty method definitions on a single line. (https://github.com/bbatsov/ruby-style-guide#no-single-line-methods) def debug(*args) ...

  3. spec/pdc/resource/path_spec.rb:16:18: C: Style/SymbolArray: Use %i or %I for an array of symbols. (https://github.com/bbatsov/ruby-style-guide#percent-i) assert_equal [:user_id, :id], path.variables

  4. spec/pdc/v1/release_spec.rb:31:7: C: Style/CommentedKeyword: Do not place comments on the same line as the end keyword. end # count ...

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.835% when pulling 150d4100ab26aed1c8746c07b70e11b4da2d70f6 on simozhan:fix_pronto_errors into 190af62bfbecff904fb99f3ab24c076286b0d154 on product-definition-center:master.